Converted the autotest test suite to void-safety

+ cosmetics

test/autotest/test_suite/test_json_suite.e

@@ -24,350 +24,467 @@ feature {NONE} -- Events
 			create file_reader
 		end
 
-
 feature -- Tests Pass
 
 	test_json_pass1
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir + "pass1.json")
+			if attached json_file_from ("pass1.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("pass1.json",parse_json.is_parsed = True)
 			end
+		end
 
 	test_json_pass2
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"pass2.json")
+			if attached json_file_from ("pass2.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("pass2.json",parse_json.is_parsed = True)
 			end
+		end
 
     test_json_pass3
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"pass3.json")
+			if attached json_file_from ("pass3.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("pass3.json",parse_json.is_parsed = True)
 			end
+		end
 
 feature -- Tests Failures
     test_json_fail1
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail1.json")
+			if attached json_file_from ("fail1.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail1.json",parse_json.is_parsed = False)
 			end
+		end
 
     test_json_fail2
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail2.json")
+			if attached json_file_from ("fail2.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail2.json",parse_json.is_parsed = False)
 			end
+		end
 
 	test_json_fail3
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail3.json")
+			if attached json_file_from ("fail3.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail3.json",parse_json.is_parsed = False)
 			end
+		end
 
 	test_json_fail4
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail4.json")
+			if attached json_file_from ("fail4.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail4.json",parse_json.is_parsed = False)
 			end
+		end
 
     test_json_fail5
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail5.json")
+			if attached json_file_from ("fail5.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail5.json",parse_json.is_parsed = False)
 			end
+		end
 
 
 	test_json_fail6
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail6.json")
+			if attached json_file_from ("fail6.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail6.json",parse_json.is_parsed = False )
 			end
+		end
 
  	test_json_fail7
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail7.json")
+			if attached json_file_from ("fail7.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail7.json",parse_json.is_parsed = False)
 			end
+		end
 
   	test_json_fail8
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail8.json")
+			if attached json_file_from ("fail8.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail8.json",parse_json.is_parsed = False )
 			end
+		end
 
 
 	test_json_fail9
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail9.json")
+			if attached json_file_from ("fail9.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail9.json",parse_json.is_parsed = False)
 			end
+		end
 
 
 	test_json_fail10
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail10.json")
+			if attached json_file_from ("fail10.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail10.json",parse_json.is_parsed = False)
 			end
+		end
 
    	test_json_fail11
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail11.json")
+			if attached json_file_from ("fail11.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail11.json",parse_json.is_parsed = False)
 			end
+		end
 
 	test_json_fail12
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail12.json")
+			if attached json_file_from ("fail12.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail12.json",parse_json.is_parsed = False)
 			end
+		end
 
     test_json_fail13
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail13.json")
+			if attached json_file_from ("fail13.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail13.json",parse_json.is_parsed = False)
 			end
+		end
 
   	test_json_fail14
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail14.json")
+			if attached json_file_from ("fail14.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail14.json",parse_json.is_parsed = False)
 			end
+		end
 
 	test_json_fail15
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail15.json")
+			if attached json_file_from ("fail15.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail15.json",parse_json.is_parsed = False)
 			end
+		end
 
 	test_json_fail16
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail16.json")
+			if attached json_file_from ("fail16.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail16.json",parse_json.is_parsed = False)
 			end
+		end
 
 	test_json_fail17
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail17.json")
+			if attached json_file_from ("fail17.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail17.json",parse_json.is_parsed = False)
 			end
+		end
 
 	test_json_fail18
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail18.json")
+			if attached json_file_from ("fail18.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail18.json",parse_json.is_parsed = True)
 			end
+		end
 
 	test_json_fail19
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail19.json")
+			if attached json_file_from ("fail19.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail19.json",parse_json.is_parsed = False)
 			end
+		end
 
 	test_json_fail20
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail20.json")
+			if attached json_file_from ("fail20.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail20.json",parse_json.is_parsed = False)
 			end
+		end
 
     test_json_fail21
     		--
+		local
+			parse_json: like new_json_parser
 		do
-				json_file:=file_reader.read_json_from (test_dir +"fail21.json")
+			if attached json_file_from ("fail21.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail21.json",parse_json.is_parsed = False)
 			end
+		end
 
 
  	test_json_fail22
     		--
+		local
+			parse_json: like new_json_parser
 		do
-				json_file:=file_reader.read_json_from (test_dir +"fail22.json")
+			if attached json_file_from ("fail22.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail22.json",parse_json.is_parsed = False)
 			end
+		end
 
     test_json_fail23
     		--
+		local
+			parse_json: like new_json_parser
 		do
-				json_file:=file_reader.read_json_from (test_dir +"fail23.json")
+			if attached json_file_from ("fail23.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail23.json",parse_json.is_parsed = False)
 			end
+		end
 
  	test_json_fail24
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail24.json")
+			if attached json_file_from ("fail24.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail24.json",parse_json.is_parsed = False)
 			end
+		end
 
 	test_json_fail25
     		--
+		local
+			parse_json: like new_json_parser
 		do
-				json_file:=file_reader.read_json_from (test_dir +"fail25.json")
+			if attached json_file_from ("fail25.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail25.json",parse_json.is_parsed = False)
 			end
+		end
 
 
    	test_json_fail26
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail26.json")
+			if attached json_file_from ("fail26.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail26.json",parse_json.is_parsed = False)
 			end
+		end
 
 
    	test_json_fail27
     		--
+		local
+			parse_json: like new_json_parser
 		do
-				json_file:=file_reader.read_json_from (test_dir +"fail27.json")
+			if attached json_file_from ("fail27.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail27.json",parse_json.is_parsed = False)
 			end
+		end
 
 
    	test_json_fail28
     		--
+		local
+			parse_json: like new_json_parser
 		do
-				json_file:=file_reader.read_json_from (test_dir +"fail28.json")
+			if attached json_file_from ("fail28.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail28.json",parse_json.is_parsed = False)
 			end
+		end
 
 
    	test_json_fail29
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail29.json")
+			if attached json_file_from ("fail29.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail29.json",parse_json.is_parsed = False )
 			end
+		end
 
 
    	test_json_fail30
     		--
+		local
+			parse_json: like new_json_parser
 		do
-				json_file:=file_reader.read_json_from (test_dir +"fail30.json")
+			if attached json_file_from ("fail30.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail30.json",parse_json.is_parsed = False)
 			end
+		end
 
 	test_json_fail31
     		--
+		local
+			parse_json: like new_json_parser
 		do
-				json_file:=file_reader.read_json_from (test_dir +"fail31.json")
+			if attached json_file_from ("fail31.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail31.json",parse_json.is_parsed = False)
 			end
+		end
 
     test_json_fail32
     		--
+		local
+			parse_json: like new_json_parser
 		do
-    			json_file:=file_reader.read_json_from (test_dir +"fail32.json")
+			if attached json_file_from ("fail32.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail32.json",parse_json.is_parsed = False)
 			end
+		end
 
     test_json_fail33
     		--
+		local
+			parse_json: like new_json_parser
 		do
-				json_file:=file_reader.read_json_from (test_dir +"fail33.json")
+			if attached json_file_from ("fail33.json") as json_file then
-				create parse_json.make_parser (json_file)
+				parse_json := new_json_parser (json_file)
 				json_value := parse_json.parse_json
 				assert ("fail33.json",parse_json.is_parsed = False)
 			end
+		end
 
 feature -- JSON_FROM_FILE
 
-	json_file : STRING
-	parse_json : JSON_PARSER
-	json_object : JSON_OBJECT
 	file_reader: JSON_FILE_READER
-	json_value : JSON_VALUE
+
+	json_value: detachable JSON_VALUE
+
+   	json_file_from (fn: STRING): detachable STRING
+		do
+			Result := file_reader.read_json_from (test_dir + fn)
+			assert ("File contains json data", Result /= Void)
+		end
+
+	new_json_parser (a_string: STRING): JSON_PARSER
+		do
+			create Result.make_parser (a_string)
+		end
+
 	test_dir: STRING
 		local
 			i: INTEGER
@@ -388,8 +505,10 @@ feature -- JSON_FROM_FILE
 			end
 --			Result := "/home/jvelilla/work/project/Eiffel/ejson_dev/trunk/test/autotest/test_suite/"	
 		end
+
 invariant
 	file_reader /= Void
+
 end
 
 

test/autotest/test_suite/test_suite-safe.ecf

@@ -7,7 +7,7 @@
 			<exclude>/CVS$</exclude>
 			<exclude>/.svn$</exclude>
 		</file_rule>
-		<option warning="true" void_safety="all" syntax="standard">
+		<option warning="true" is_attached_by_default="true" void_safety="all" syntax="standard">
 			<assertions precondition="true" postcondition="true" check="true" invariant="true" loop="true" supplier_precondition="true"/>
 		</option>
 		<library name="base" location="$ISE_LIBRARY\library\base\base-safe.ecf"/>