Implemented custom cms format, and associated administration pages.

Applied to existing filter and format.
Added embedded_video filter (initially contribute by Javier Velilla).

modules/admin/admin-safe.ecf

@@ -20,6 +20,7 @@
 		<library name="error" location="$ISE_LIBRARY\contrib\library\utility\general\error\error-safe.ecf"/>
 		<library name="http" location="$ISE_LIBRARY\contrib\library\network\protocol\http\http-safe.ecf"/>
 		<library name="http_authorization" location="$ISE_LIBRARY\contrib\library\web\authentication\http_authorization\http_authorization-safe.ecf" readonly="false"/>
+		<library name="text_filter" location="$ISE_LIBRARY\unstable\library\text\text_filter\text_filter-safe.ecf"/>
 		<library name="time" location="$ISE_LIBRARY\library\time\time-safe.ecf"/>
 		<library name="wsf" location="$ISE_LIBRARY\contrib\library\web\framework\ewf\wsf\wsf-safe.ecf"/>
 		<library name="wsf_extension" location="$ISE_LIBRARY\contrib\library\web\framework\ewf\wsf\wsf_extension-safe.ecf" readonly="false"/>

modules/admin/cms_admin_module_administration.e

@@ -36,6 +36,7 @@ feature -- Security
 			Result.force ("clear blocks cache")
 			Result.force ("admin export")
 			Result.force ("admin import")
+			Result.force ("admin formats")
 		end
 
 feature {NONE} -- Router/administration
@@ -48,6 +49,7 @@ feature {NONE} -- Router/administration
 			l_modules_handler: CMS_ADMIN_MODULES_HANDLER
 			l_users_handler: CMS_ADMIN_USERS_HANDLER
 			l_roles_handler: CMS_ADMIN_ROLES_HANDLER
+			l_formats_handler: CMS_ADMIN_FORMATS_HANDLER
 
 			l_user_handler: CMS_USER_HANDLER
 			l_role_handler:	CMS_ROLE_HANDLER
@@ -58,6 +60,7 @@ feature {NONE} -- Router/administration
 			l_admin_import_handler: CMS_ADMIN_IMPORT_HANDLER
 			l_admin_path_alias_handler: CMS_ADMIN_PATH_ALIAS_HANDLER
 
+
 			l_uri_mapping: WSF_URI_MAPPING
 		do
 			create l_admin_handler.make (a_api)
@@ -76,6 +79,13 @@ feature {NONE} -- Router/administration
 			create l_uri_mapping.make_trailing_slash_ignored ("/roles", l_roles_handler)
 			a_router.map (l_uri_mapping, a_router.methods_get_post)
 
+			create l_formats_handler.make (a_api)
+			create l_uri_mapping.make_trailing_slash_ignored ("/formats", l_formats_handler)
+			a_router.map (l_uri_mapping, a_router.methods_get_post)
+			create l_uri_mapping.make_trailing_slash_ignored ("/formats", l_formats_handler)
+			a_router.handle ("/formats/{format-id}", l_formats_handler, a_router.methods_get_post)
+			a_router.handle ("/formats/{format-id}/add", l_formats_handler, a_router.methods_get_post)
+
 			create l_admin_logs_handler.make (a_api)
 			create l_uri_mapping.make_trailing_slash_ignored ("/logs", l_admin_logs_handler)
 			a_router.map (l_uri_mapping, a_router.methods_get)
@@ -108,6 +118,7 @@ feature {NONE} -- Router/administration
 			a_router.handle ("/role/{id}", l_role_handler, a_router.methods_get)
 			a_router.handle ("/role/{id}/edit", l_role_handler, a_router.methods_get_post)
 			a_router.handle ("/role/{id}/delete", l_role_handler, a_router.methods_get_post)
+
 		end
 
 feature -- Hooks
@@ -137,6 +148,10 @@ feature -- Hooks
 
 				create lnk.make ("Module", l_api.administration_path_location ("modules"))
 				lnk.set_permission_arguments (<<"manage module">>)
+				admin_lnk.extend (lnk)
+
+				create lnk.make ("Formats", l_api.administration_path_location ("formats"))
+				lnk.set_permission_arguments (<<"admin formats">>)
 				admin_lnk.extend (lnk)
 
 					-- Per module cache permission!

modules/blog/cms_blog_module.e

@@ -60,12 +60,6 @@ feature {CMS_API} -- Module Initialization
 
 				node_api := l_node_api
 					-- Depends on {CMS_NODE_MODULE}
-					--| For now, add all available formats to content type `ct'.
-				across
-					api.formats as ic
-				loop
-					ct.extend_format (ic.item)
-				end
 				l_node_api.add_node_type (ct)
 				l_node_api.add_node_type_webform_manager (create {CMS_BLOG_NODE_TYPE_WEBFORM_MANAGER}.make (ct, l_node_api))
 			end

modules/embedded_video/embedded_video-safe.ecf

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="ISO-8859-1"?>
+<system xmlns="http://www.eiffel.com/developers/xml/configuration-1-15-0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.eiffel.com/developers/xml/configuration-1-15-0 http://www.eiffel.com/developers/xml/configuration-1-15-0.xsd" name="embedded_video" uuid="1469E34C-98EE-4E39-BC13-24A0D93A7EC0" library_target="embedded_video">
+	<target name="embedded_video">
+		<root all_classes="true"/>
+		<option warning="true" void_safety="all">
+		</option>
+		<setting name="concurrency" value="scoop"/>
+		<library name="base" location="$ISE_LIBRARY\library\base\base-safe.ecf"/>
+		<library name="cms" location="..\..\cms-safe.ecf" readonly="false"/>
+		<library name="text_filter" location="$ISE_LIBRARY\unstable\library\text\text_filter\text_filter-safe.ecf"/>
+		<library name="wsf" location="$ISE_LIBRARY\contrib\library\web\framework\ewf\wsf\wsf-safe.ecf"/>
+		<cluster name="src" location="src\" recursive="true"/>
+	</target>
+</system>

modules/embedded_video/src/embedded_video_module.e

@@ -0,0 +1,61 @@
+note
+	description: "[
+		Module that allows you to embed videos from YouTube and Vimeo in a web page.
+	]"
+	date: "$Date: 2015-07-16 15:57:08 +0200 (jeu., 16 juil. 2015) $"
+	revision: "$Revision: 97722 $"
+
+class
+	EMBEDDED_VIDEO_MODULE
+
+inherit
+
+	CMS_MODULE
+		redefine
+			initialize
+		end
+
+	SHARED_EXECUTION_ENVIRONMENT
+		export
+			{NONE} all
+		end
+
+	REFACTORING_HELPER
+
+create
+	make
+
+feature {NONE} -- Initialization
+
+	make
+			-- Create current module
+		do
+			version := "1.0"
+			description := "Embedded video module"
+			package := "filters"
+		end
+
+feature -- Access
+
+	name: STRING = "embedded_video"
+			-- <Precursor>
+
+feature {CMS_API} -- Module Initialization
+
+	initialize (api: CMS_API)
+			-- <Precursor>
+		do
+			Precursor {CMS_MODULE} (api)
+			api.content_filters.extend (create {VIDEO_CONTENT_FILTER})
+--			f := api.new_format ("video_html", "Video HTML content", <<{VIDEO_CONTENT_FILTER}.name>>)
+--			api.formats.extend (f)
+		end
+
+feature -- Router
+
+	setup_router (a_router: WSF_ROUTER; a_api: CMS_API)
+			-- Router configuration.
+		do
+		end
+
+end

modules/embedded_video/src/video_content_filter.e

@@ -0,0 +1,182 @@
+note
+	description: "[
+		Quick syntax:
+			[video:url]
+		Full syntax:
+			[video:url width:X height:Y]
+	]"
+	date: "$Date: 2015-07-18 13:53:56 +0200 (sam., 18 juil. 2015) $"
+	revision: "$Revision: 97737 $"
+
+class
+	VIDEO_CONTENT_FILTER
+
+inherit
+
+	CONTENT_FILTER
+		redefine
+			help,
+			default_create
+		end
+
+feature {NONE} -- Initialization
+
+	default_create
+		do
+			Precursor
+			width := 420
+			height := 315
+		end
+
+feature -- Access
+
+	name: STRING_8 = "video"
+
+	title: STRING_8 = "Embedded video"
+
+	description: STRING_8 = "Embed any video using pattern [video:url width:X height:Y], width and height are optionals."
+
+	help: STRING = "Embed video using the following pattern: [video:url width:X height:Y], width and height are optionals."
+
+feature -- Conversion
+
+	filter (a_text: STRING_8)
+			-- [video:url width:X height:Y]
+		local
+			l_new: detachable STRING
+			i,p,q,diff: INTEGER
+		do
+			from
+				i := 1
+			until
+				i > a_text.count
+			loop
+				p := a_text.substring_index ("[video:", i)
+				if p > 0 then
+					q := a_text.index_of (']', p + 1)
+					l_new := to_embedded_video_code (a_text, p, q)
+					if l_new /= Void then
+						diff := l_new.count - (q - p + 1)
+						i := i + diff
+						a_text.replace_substring (l_new, p, q)
+					else
+						i := q + 1
+					end
+				else
+					i := a_text.count
+				end
+				i := i + 1
+			end
+		end
+
+	to_embedded_video_code (a_text: STRING_8; a_lower, a_upper: INTEGER): detachable STRING
+		require
+			a_lower < a_upper
+			a_text.substring (a_lower, a_lower + 7).same_string ("[video:")
+			a_text.ends_with_general ("]")
+		local
+			i,j,n: INTEGER
+			s,k,v: STRING_8
+			l_url: STRING_8
+			l_width, l_height: detachable STRING
+		do
+			s := a_text.substring (a_lower + 1, a_upper - 1)
+			s.left_adjust
+			i := next_space_position (s, 1)
+			if i > 0 then
+				l_url := s.head (i - 1)
+				s.remove_head (i)
+				s.left_adjust
+				from
+					n := s.count
+					i := 1
+				until
+					i > n
+				loop
+					j := s.index_of (':', i)
+					if j > 0 then
+						k := s.head (j - 1)
+						s.remove_head (j)
+						s.left_adjust
+						i := 1
+						n := s.count
+						j := next_space_position (s, 1)
+						if j > 0 then
+							v := s.head (j - 1)
+							s.remove_head (j)
+							s.left_adjust
+						else
+							v := s.substring (i, n)
+							s.wipe_out
+						end
+						n := s.count
+						i := 1
+						if k.is_case_insensitive_equal ("width") then
+							l_width := v
+						elseif k.is_case_insensitive_equal ("height") then
+							l_height := v
+						else
+							check supported: False end
+						end
+					else
+						i := n + 1
+					end
+				end
+			else
+				s.remove_head (6)
+				l_url := s
+			end
+			if not l_url.is_whitespace then
+				create Result.make_from_string ("<iframe src=%"")
+				Result.append (l_url)
+				Result.append_character ('%"')
+				if l_width = Void then
+					if width > 0 then
+						l_width := width.out
+					end
+				end
+				if l_height = Void then
+					if height > 0 then
+						l_height := height.out
+					end
+				end
+				if l_width /= Void then
+					Result.append (" width=%"")
+					Result.append (l_width)
+					Result.append_character ('%"')
+				end
+				if l_height /= Void then
+					Result.append (" height=%"")
+					Result.append (l_height)
+					Result.append_character ('%"')
+				end
+				Result.append ("frameborder=%"0%" allowfullscreen></iframe>")
+			end
+		end
+
+	next_space_position (a_text: STRING; a_start_index: INTEGER): INTEGER
+		local
+			n: INTEGER
+		do
+			from
+				Result := a_start_index
+				n := a_text.count
+			until
+				a_text[Result].is_space or Result > n
+			loop
+				Result := Result + 1
+			end
+			if Result > n then
+				Result := 0
+			end
+		end
+
+feature {NONE} -- Implementation
+
+	width: INTEGER;
+		-- Specifies the width of an <iframe> in pixels.
+
+	height: INTEGER
+			-- Specifies the height of an <iframe> in pixels.
+
+end

modules/embedded_video/src/video_html_content_format.e

@@ -0,0 +1,34 @@
+note
+	description: "Summary description for {VIDEO_HTML_CONTENT_FORMAT}."
+	author: ""
+	date: "$Date: 2015-07-10 13:38:10 +0200 (ven., 10 juil. 2015) $"
+	revision: "$Revision: 97687 $"
+
+class
+	VIDEO_HTML_CONTENT_FORMAT
+
+inherit
+
+	CONTENT_FORMAT
+		redefine
+			default_create
+		end
+
+feature {NONE} -- Initialization
+
+	default_create
+		do
+			Precursor
+			create filters.make (0)
+			filters.force (create {VIDEO_CONTENT_FILTER})
+		end
+
+feature -- Access
+
+	name: STRING = "video_html"
+
+	title: STRING_8 = "Video HTML content"
+
+	filters: ARRAYED_LIST [CONTENT_FILTER]
+
+end

modules/embedded_video/test/test_content_filter_set.e

@@ -0,0 +1,183 @@
+note
+	description: "[
+		Eiffel tests that can be executed by testing tool.
+	]"
+	author: "EiffelStudio test wizard"
+	date: "$Date: 2015-07-10 13:38:10 +0200 (ven., 10 juil. 2015) $"
+	revision: "$Revision: 97687 $"
+	testing: "type/manual"
+
+class
+	TEST_CONTENT_FILTER_SET
+
+inherit
+	EQA_TEST_SET
+
+feature -- Test routines
+
+	test_video_filter
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[video:https://www.youtube.com/embed/jBMOSSnCMCk]"
+			expected_text := "<iframe width=%"420%" height=%"315%"%Nsrc=%"https://www.youtube.com/embed/jBMOSSnCMCk%">%N</iframe>"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+
+	test_video_filter_2
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[ video :  https://www.youtube.com/embed/jBMOSSnCMCk   ]"
+			expected_text := "<iframe width=%"420%" height=%"315%"%Nsrc=%"https://www.youtube.com/embed/jBMOSSnCMCk%">%N</iframe>"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+
+	test_video_filter_3
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[ video :https://www.youtube.com/embed/jBMOSSnCMCk   ]"
+			expected_text := "<iframe width=%"420%" height=%"315%"%Nsrc=%"https://www.youtube.com/embed/jBMOSSnCMCk%">%N</iframe>"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+
+	test_video_filter_4
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[ video :https://www.youtube.com/embed/jBMOSSnCMCk   height:425]"
+			expected_text := "<iframe width=%"420%" height=%"425%"%Nsrc=%"https://www.youtube.com/embed/jBMOSSnCMCk%">%N</iframe>"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+
+	test_video_filter_5
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[ video :https://www.youtube.com/embed/jBMOSSnCMCk   height :  425]"
+			expected_text := "<iframe width=%"420%" height=%"425%"%Nsrc=%"https://www.youtube.com/embed/jBMOSSnCMCk%">%N</iframe>"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+
+	test_video_filter_6
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[ video :https://www.youtube.com/embed/jBMOSSnCMCk   height :  425 width:   425]"
+			expected_text := "<iframe width=%"425%" height=%"425%"%Nsrc=%"https://www.youtube.com/embed/jBMOSSnCMCk%">%N</iframe>"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+	test_video_filter_7
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[video:https://www.youtube.com/embed/jBMOSSnCMCk height:425 width:425]"
+			expected_text := "<iframe width=%"425%" height=%"425%"%Nsrc=%"https://www.youtube.com/embed/jBMOSSnCMCk%">%N</iframe>"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+
+	test_video_filter_8
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[height:425 width:425 video:https://www.youtube.com/embed/jBMOSSnCMCk ]"
+			expected_text := "<iframe width=%"425%" height=%"425%"%Nsrc=%"https://www.youtube.com/embed/jBMOSSnCMCk%">%N</iframe>"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+
+	test_video_filter_9
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[ width:425  video:https://www.youtube.com/embed/jBMOSSnCMCk  height:425]"
+			expected_text := "<iframe width=%"425%" height=%"425%"%Nsrc=%"https://www.youtube.com/embed/jBMOSSnCMCk%">%N</iframe>"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+	test_video_filter_10
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[ wrong:425  video:https://www.youtube.com/embed/jBMOSSnCMCk  height:425]"
+			expected_text := "<iframe width=%"420%" height=%"425%"%Nsrc=%"https://www.youtube.com/embed/jBMOSSnCMCk%">%N</iframe>"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+
+	test_video_filter_11
+			-- New test routine
+		local
+			f: VIDEO_CONTENT_FILTER
+			text: STRING
+			expected_text: STRING
+		do
+			text := "[wrong hello:1020 ]"
+			expected_text := "[wrong hello:1020 ]"
+			create f
+			f.filter (text)
+			assert ("expected iframe with video", text.same_string (expected_text))
+		end
+
+
+end
+
+

modules/embedded_video/test/testing-safe.ecf

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="ISO-8859-1"?>
+<redirection xmlns="http://www.eiffel.com/developers/xml/configuration-1-16-0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.eiffel.com/developers/xml/configuration-1-16-0 http://www.eiffel.com/developers/xml/configuration-1-16-0.xsd" uuid="BD491995-C14C-4413-B09A-C1B4EDDA3116" message="Obsolete: use testing.ecf !" location="testing.ecf">
+</redirection>

modules/embedded_video/test/testing.ecf

@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="ISO-8859-1"?>
+<system xmlns="http://www.eiffel.com/developers/xml/configuration-1-16-0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.eiffel.com/developers/xml/configuration-1-16-0 http://www.eiffel.com/developers/xml/configuration-1-16-0.xsd" name="embedded_video_testing" uuid="BD491995-C14C-4413-B09A-C1B4EDDA3116">
+	<target name="embedded_video_testing">
+		<root class="ANY" feature="default_create"/>
+		<file_rule>
+			<exclude>/.git$</exclude>
+			<exclude>/.svn$</exclude>
+			<exclude>/EIFGENs$</exclude>
+		</file_rule>
+		<option warning="true">
+		</option>
+		<capability>
+			<concurrency use="none"/>
+		</capability>
+		<library name="base" location="$ISE_LIBRARY\library\base\base.ecf"/>
+		<library name="embeded_module" location="..\video.ecf"/>
+		<library name="testing" location="$ISE_LIBRARY\library\testing\testing.ecf"/>
+		<library name="text_filter" location="$ISE_LIBRARY\unstable\library\text\text_filter\text_filter.ecf"/>
+		<tests name="src" location=".\"/>
+	</target>
+</system>

modules/node/submodules/page/cms_page_api.e

@@ -54,12 +54,6 @@ feature {NONE} -- Initialization
 				-- Initialize node content types.			
 			create ct
 			page_content_type := ct
-				--| For now, add all available formats to content type `ct'.
-			across
-				cms_api.formats as ic
-			loop
-				ct.extend_format (ic.item)
-			end
 			node_api.add_node_type (ct)
 			node_api.add_node_type_webform_manager (create {CMS_PAGE_NODE_TYPE_WEBFORM_MANAGER}.make (ct, Current))
 		end

modules/wikitext/wikitext_module.e

@@ -39,18 +39,12 @@ feature {CMS_API} -- Module Initialization
 
 	initialize (api: CMS_API)
 			-- <Precursor>
-		local
-			f: CMS_FORMAT
 		do
 			Precursor (api)
 
-			create f.make_from_format (create {WIKITEXT_FORMAT})
-			api.formats.extend (f)
-				-- FIXME!!!
-			across
-				api.content_types as ic
-			loop
-				ic.item.extend_format (f)
+			api.content_filters.extend (create {WIKITEXT_FILTER})
+			if api.format ({WIKITEXT_FORMAT}.name) = Void then
+				api.formats.extend (api.new_format ("wikitext", "Wikitext rendered as HTML", <<{WIKITEXT_FILTER}.name>>))
 			end
 		end