From e41b0631d65a0d05a2d295689b2a7b78a9f04d64 Mon Sep 17 00:00:00 2001 From: jvelilla Date: Thu, 9 Apr 2015 22:45:37 -0300 Subject: [PATCH] Added missing descriptions --- library/layout/src/logger/logger.e | 11 +++++++++-- library/layout/src/logger/logging_facility.e | 2 +- library/model/src/content/cms_node.e | 14 +------------- src/modules/basic_auth/filter/basic_auth_filter.e | 2 ++ 4 files changed, 13 insertions(+), 16 deletions(-) diff --git a/library/layout/src/logger/logger.e b/library/layout/src/logger/logger.e index 032cdbe..3e50e72 100644 --- a/library/layout/src/logger/logger.e +++ b/library/layout/src/logger/logger.e @@ -1,6 +1,5 @@ note - description: "Summary description for {LOGGER}." - author: "" + description: "Object to log messages for a specific application. " date: "$Date$" revision: "$Revision$" @@ -27,11 +26,13 @@ create feature {NONE} -- Initialization make + -- Initialize a logger object. do create log.make end make_with_layout (app: APPLICATION_LAYOUT) + -- Initialize a logger object with an application layout `app'. do make apply_layout (app) @@ -51,31 +52,37 @@ feature {NONE} -- Internal feature -- Logging put_information (a_message: separate READABLE_STRING_8) + -- Put message `a_message' to the log at information level. do log.write_information (create {STRING}.make_from_separate (a_message)) end put_error (a_message: separate READABLE_STRING_8) + -- Put message `a_message' to the log at error level. do log.write_error (create {STRING}.make_from_separate (a_message)) end put_warning (a_message: separate READABLE_STRING_8) + -- Put message `a_message' to the log at warning level. do log.write_warning (create {STRING}.make_from_separate (a_message)) end put_critical (a_message: separate READABLE_STRING_8) + -- Put message `a_message' to the log at critical level. do log.write_critical (create {STRING}.make_from_separate (a_message)) end put_alert (a_message: separate READABLE_STRING_8) + -- Put message `a_message' to the log at alert level. do log.write_alert (create {STRING}.make_from_separate (a_message)) end put_debug (a_message: separate READABLE_STRING_8) + -- Put message `a_message' to the log at debug level. do log.write_debug (create {STRING}.make_from_separate (a_message)) end diff --git a/library/layout/src/logger/logging_facility.e b/library/layout/src/logger/logging_facility.e index 0b87e88..00aa5b0 100644 --- a/library/layout/src/logger/logging_facility.e +++ b/library/layout/src/logger/logging_facility.e @@ -22,7 +22,7 @@ feature -- Access register_log_writer (a_log_writer: LOG_WRITER) - -- -- Register the non-default log writer `a_log_writer'. + -- Register the non-default log writer `a_log_writer'. do logging.register_log_writer (a_log_writer) end diff --git a/library/model/src/content/cms_node.e b/library/model/src/content/cms_node.e index 072d9c1..6956776 100644 --- a/library/model/src/content/cms_node.e +++ b/library/model/src/content/cms_node.e @@ -57,6 +57,7 @@ feature -- Access id: INTEGER_64 assign set_id -- Unique id. + --| Should we use NATURAL_64 instead? content: READABLE_STRING_32 -- Content of the node. @@ -181,19 +182,6 @@ feature -- Element change auther_set: author = u end --- add_collaborator (a_user: CMS_USER) --- -- Add collaborator `a_user' to the collaborators list. --- local --- lst: like collaborators --- do --- lst := collaborators --- if lst = Void then --- create {ARRAYED_SET [CMS_USER]} lst.make (1) --- collaborators := lst --- end --- lst.force (a_user) --- end - note copyright: "2011-2015, Javier Velilla, Jocelyn Fiat, Eiffel Software and others" license: "Eiffel Forum License v2 (see http://www.eiffel.com/licensing/forum.txt)" diff --git a/src/modules/basic_auth/filter/basic_auth_filter.e b/src/modules/basic_auth/filter/basic_auth_filter.e index 158d4be..9c47c03 100644 --- a/src/modules/basic_auth/filter/basic_auth_filter.e +++ b/src/modules/basic_auth/filter/basic_auth_filter.e @@ -21,6 +21,8 @@ feature -- Basic operations local l_auth: HTTP_AUTHORIZATION do + -- We can inherit from SHARED_LOGGER and write + -- write_debug_log ... api.logger.put_debug (generator + ".execute ", Void) create l_auth.make (req.http_authorization) if attached req.raw_header_data as l_raw_data then