Fixed persistency layer.

Now we have ODBC .. that accepts various connection string (including SQLite, MySQL,...)
  And EiffelStore+MySQL.
Updated sql scripts to work with MySQL, and SQLite.
Added a sql_statement (s: STRING): STRING that converts ROC sql statement to fit the underlying database engine.
 mostly to adapt incompatibilities such as AUTO_INCREMENT for MySQL and AUTOINCREMENT for SQLite
 by default SQL script should be written following MySQL SQL syntax.
Warning: to use ODBC persistence driver, it has to be installed on the target machine.

library/persistence/implementation/store/database/database_config.e

@@ -8,16 +8,16 @@ deferred class
 
 feature -- Database access
 
-	hostname: STRING = ""
+	default_hostname: STRING = ""
 			-- Database hostname.
 
-	username: STRING = ""
+	default_username: STRING = ""
 			-- Database username.
 
-	password: STRING = ""
+	default_password: STRING = ""
 			-- Database password.
 
-	database_name: STRING = "EiffelDB"
+	default_database_name: STRING = "EiffelDB"
 			-- Database name.
 
 	is_keep_connection: BOOLEAN

library/persistence/implementation/store/database/database_connection.e

@@ -12,27 +12,7 @@ inherit
 
 feature {NONE} -- Initialization
 
-	make_common
-			-- Create a database handler with common settings.
-		deferred
-		ensure
-			db_application_not_void: db_application /= Void
-			db_control_not_void: db_control /= Void
-		end
-
-	make_basic ( a_database_name: STRING)
-			-- Create a database handler with common settings and
- 			-- set database_name with `a_database_name'.
-		require
-			database_name_not_void: a_database_name /= Void
-			database_name_not_empty: not a_database_name.is_empty
-		deferred
-		ensure
-			db_application_not_void: db_application /= Void
-			db_control_not_void: db_control /= Void
-		end
-
-	make (a_username: STRING; a_password: STRING; a_hostname: STRING; a_database_name: STRING; connection: BOOLEAN)
+	login (a_username: STRING; a_password: STRING; a_hostname: STRING; a_database_name: STRING; connection: BOOLEAN)
 
 			-- Create a database handler with user `a_username', password `a_password',
 			-- host `a_hostname', database_name `a_database_name', and keep_connection `connection'.
@@ -59,6 +39,26 @@ feature {NONE} -- Initialization
 			db_control_not_void: db_control /= Void
 		end
 
+	login_with_default
+			-- Create a database handler with common settings.
+		deferred
+		ensure
+			db_application_not_void: db_application /= Void
+			db_control_not_void: db_control /= Void
+		end
+
+	login_with_database_name ( a_database_name: STRING)
+			-- Create a database handler with common settings and
+ 			-- set database_name with `a_database_name'.
+		require
+			database_name_not_void: a_database_name /= Void
+			database_name_not_empty: not a_database_name.is_empty
+		deferred
+		ensure
+			db_application_not_void: db_application /= Void
+			db_control_not_void: db_control /= Void
+		end
+
 feature -- Database Setup
 
 	db_application: DATABASE_APPL [DATABASE]
@@ -168,7 +168,7 @@ feature -- Error Handling
 
 	database_error_handler: DATABASE_ERROR_HANDLER
 			-- Error handler.
-	
+
 feature -- Status Report
 
 	has_error: BOOLEAN
@@ -179,11 +179,11 @@ feature -- Status Report
 
 feature -- Helper
 
-	exception_as_error (a_e: like {EXCEPTION_MANAGER}.last_exception)
-			-- Record exception as an error.
+	exception_as_error (a_exception: like {EXCEPTION_MANAGER}.last_exception)
+			-- Record exception `a_exception' as an error.
 		do
-			if attached a_e as l_e and then attached l_e.trace as l_trace then
-				database_error_handler.add_error_details (l_e.code, once "Exception", l_trace.as_string_32)
+			if a_exception /= Void and then attached a_exception.trace as l_trace then
+				database_error_handler.add_error_details (a_exception.code, once "Exception", l_trace)
 			end
 		end
 

library/persistence/implementation/store/database/database_connection_odbc.e

@@ -7,117 +7,97 @@ class
 	DATABASE_CONNECTION_ODBC
 
 inherit
-
 	DATABASE_CONNECTION
 		redefine
 			db_application
 		end
 
-	SHARED_LOGGER
-
 create
-	make, make_common, make_basic, login_with_connection_string
+	login, login_with_default, login_with_database_name, login_with_connection_string
 
 feature -- Initialization
 
-	make_common
-			-- Create a database handler for ODBC with common settings.
-		local
-			l_retried: BOOLEAN
-		do
-			create db_application.login (username, password)
-			create database_error_handler.make
-			if not l_retried then
-				db_application.set_hostname (hostname)
-				db_application.set_data_source (database_name)
-				db_application.set_base
-				create db_control.make
-				keep_connection := is_keep_connection
-				if keep_connection then
-					connect
-				end
-			else
-				create db_control.make
-			end
-		rescue
-			create db_control.make
---			set_last_error_from_exception ("Connection execution")
---			write_critical_log (generator + ".make_common:" + last_error_message)
-			if is_connected then
-				disconnect
-			end
-			l_retried := True
-			retry
-		end
-
-	make_basic (a_database_name: STRING)
-			-- Create a database handler and
-			-- set database_name to `a_database_name'.
-		local
-			l_retried: BOOLEAN
-		do
-			create db_application.login (username, password)
-			create database_error_handler.make
-			if not l_retried then
-				db_application.set_hostname (hostname)
-				db_application.set_data_source (a_database_name)
-				db_application.set_base
-				create db_control.make
-				keep_connection := is_keep_connection
-				if keep_connection then
-					connect
-				end
-			else
-				create db_control.make
-			end
-		rescue
-			create db_control.make
---			set_last_error_from_exception ("Connection execution")
---			write_critical_log (generator + ".make_common:" + last_error_message)
-			if is_connected then
-				disconnect
-			end
-			l_retried := True
-			retry
-		end
-
-	make (a_username: STRING; a_password: STRING; a_hostname: STRING; a_database_name: STRING; connection: BOOLEAN)
+	login (a_username: STRING; a_password: STRING; a_hostname: STRING; a_database_name: STRING; a_keep_connection: BOOLEAN)
 
 			-- Create a database handler for ODBC and set `username' to `a_username',
 			-- `password' to `a_password'
 			-- `database_name' to `a_database_name'
-			-- `connection' to `a_connection'
+			-- `keep_connection' to `a_keep_connection'
+		local
+			retried: BOOLEAN
+			l_database_error_handler: detachable like database_error_handler
 		do
-			create database_error_handler.make
+			create l_database_error_handler.make
+			database_error_handler := l_database_error_handler
 			create db_application.login (a_username, a_password)
-			db_application.set_hostname (a_hostname)
-			db_application.set_data_source (a_database_name)
-			db_application.set_base
-			create db_control.make
-			keep_connection := connection
-			if keep_connection then
-				connect
+			if not retried then
+				db_application.set_hostname (a_hostname)
+				db_application.set_data_source (a_database_name)
+				db_application.set_base
+				create db_control.make
+				keep_connection := a_keep_connection
+				if keep_connection then
+					connect
+				end
+			else
+				create db_control.make
+				if is_connected then
+					disconnect
+				end
 			end
+		rescue
+			if l_database_error_handler = Void then
+				create l_database_error_handler.make
+			end
+			database_error_handler := l_database_error_handler
+			exception_as_error ((create {EXCEPTION_MANAGER}).last_exception)
+			retried := True
+			retry
+		end
+
+	login_with_default
+			-- Create a database handler for ODBC with common settings.
+		do
+			login_with_database_name (default_database_name)
+		end
+
+	login_with_database_name (a_database_name: STRING)
+			-- Create a database handler and
+			-- set database_name to `a_database_name'.
+		do
+			login (default_username, default_password, default_hostname, default_database_name, is_keep_connection)
 		end
 
 	login_with_connection_string (a_string: STRING)
 			-- Login with `a_connection_string'and immediately connect to database.
+		local
+			retried: BOOLEAN
+			l_database_error_handler: detachable like database_error_handler
 		do
-			write_debug_log (generator +".login_with_connection_string")
+			create l_database_error_handler.make
+			database_error_handler := l_database_error_handler
 			create db_application.login_with_connection_string (a_string)
-			create database_error_handler.make
-			db_application.set_base
-			create db_control.make
-			write_debug_log (generator +".login_with_connection_string, is_keep_connection? "+ is_keep_connection.out )
-			keep_connection := is_keep_connection
-			if keep_connection then
-				connect
-				if not db_control.is_ok then
-					write_critical_log (generator +".login_with_connection_string:"+ db_control.error_code.out )
-					write_critical_log (generator +".login_with_connection_string:"+ db_control.error_message_32 )
+			if not retried then
+				db_application.set_base
+				create db_control.make
+				keep_connection := is_keep_connection
+				if keep_connection then
+					connect
+				end
+			else
+				create db_control.make
+				if is_connected then
+					disconnect
 				end
-				write_debug_log (generator +".login_with_connection_string, After connect, is_connected? "+ is_connected.out)
 			end
+		rescue
+			if l_database_error_handler = Void then
+				create l_database_error_handler.make
+			end
+			database_error_handler := l_database_error_handler
+			exception_as_error ((create {EXCEPTION_MANAGER}).last_exception)
+			retried := True
+			retry
 		end
 
 feature -- Databse Connection